fix: force download dependencies if dependency folder doesn't exist#3582
Merged
mndeveci merged 5 commits intoaws:developfrom Jan 28, 2022
Merged
fix: force download dependencies if dependency folder doesn't exist#3582mndeveci merged 5 commits intoaws:developfrom
mndeveci merged 5 commits intoaws:developfrom
Conversation
CoshUS
approved these changes
Jan 14, 2022
Contributor
CoshUS
left a comment
CoshUS
left a comment
There was a problem hiding this comment.
LGTM. Is the case of missing dependency dir limited to user manual actions or does it happen in SAM CLI's workflow?
Contributor
Author
It happened to me when I was testing locally. Anything that causes to first build to fail (internet connection issues or killing process with |
mingkun2020
approved these changes
Jan 19, 2022
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…ws#3582) Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
When running incremental build,
download_dependenciesflag should beFalseif dependecy folder (which should be created earlier) does not exist.Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.