feat: change unformatted option into output option for sam logs and sam traces#3606
Merged
mndeveci merged 5 commits intoaws:developfrom Feb 4, 2022
Merged
Conversation
mingkun2020
approved these changes
Jan 31, 2022
CoshUS
approved these changes
Jan 31, 2022
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…am traces (aws#3606) * feat: change unformatted option into output option * move default values into command definition to use with experimental flag * fix unit tests & black formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Changes
--unformattedoption forsam logsandsam tracesinto--outputoption.Why is this change necessary?
To give more familiar name with
--outputoption. Users can choose to print output intext(default) format or injsonformat.How does it address the issue?
By changing boolean flag (unformatted) into enum flag (output).
What side effects does this change have?
Users who are using
--unformattedoption should use--output json.Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.