feat: Consume esbuild function metadata and pass to lambda builders #3613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
changed the title
…/aws-sam-cli into read-esbuild-function-metadata
hawflau
approved these changes
Feb 3, 2022
Contributor
hawflau
left a comment
hawflau
left a comment
There was a problem hiding this comment.
LGTM, approved with one minor question
| return cdk_resource_id | ||
|
|
||
| @staticmethod | ||
| def normalize_build_properties(build_props) -> Dict: |
Contributor
There was a problem hiding this comment.
question - is Lambda Builder expecting snake case for build properties in general and not only esbuild?
Contributor
Author
There was a problem hiding this comment.
BuildProperties is a new field, but everything else we send lambda builders is snake case so I wanted to keep it consistent.
moelasmar
approved these changes
Feb 3, 2022
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
…ws#3613) * Consume esbuild function metadata and pass to lambda builders * Convert lambda builders options to snake case for consistency * Determine entry point from handler * Remove comment * Remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.