add exporter for AWS::CloudFormation::StackSet resource #3674
Conversation
|
Hi guys, I can't figure out why the win build fails with a permission denied error on tests. This error doesn't happen on *nix os. Could you help me to find out the problem? Thanks |
|
Now the test is fixed. The continuous-integration/appveyor/pr/make-pr check is blocked on appveyor but it should be ok. |
|
@mildaniel @moelasmar @jfuss any news on this? It's a bug fix and is quite urgent for us. |
hawflau
left a comment
hawflau
left a comment
There was a problem hiding this comment.
Hi @maintux Thanks for your contribution. Overall LGTM. But would you please also add some integration tests? I believe that would be similar to the nested stack ones? e.g. test_package_with_deep_nested_template under tests/integration/package/test_package_command_zip.py and test_deploy_nested_stacks under tests/integration/deploy/test_deploy_command.py. Thanks!
|
Hi @hawflau, thanks for your reply. As requested I've added the missing integration tests. |
hawflau
left a comment
hawflau
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
| template_path = resource_dict.get(self.PROPERTY_NAME, None) | ||
|
|
||
| if template_path is None or is_s3_url(template_path): | ||
| # Nothing to do |
There was a problem hiding this comment.
A debug logging could be nice here to catch this case.
* add exporter for AWS::CloudFormation::StackSet resource * fix access denied error on windows * fix line too long * fix file formatting * Add integration tests for StackSet exporter * black reformat Co-authored-by: Massimo Maino <massimo.maino@claudacademy.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
5 participants
Which issue(s) does this change fix?
#2249
Why is this change necessary?
The PR #3249 was not complete
How does it address the issue?
And a custom exporter for StackSet resource
What side effects does this change have?
I think there are no side effects because is a new feature
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.