feat: Add --s3-bucket and --s3-prefix to sam delete#3915
Merged
hawflau merged 20 commits intoaws:developfrom Jun 8, 2022
Merged
feat: Add --s3-bucket and --s3-prefix to sam delete#3915hawflau merged 20 commits intoaws:developfrom
hawflau merged 20 commits intoaws:developfrom
Conversation
github-actions
bot
added
pr/external
stage/needs-triage
lucashuy
changed the title
mndeveci
reviewed
May 27, 2022
Contributor
mndeveci
left a comment
mndeveci
left a comment
There was a problem hiding this comment.
LGTM in general! 🥳 Added couple of small comments.
mingkun2020
added
pr/internal
and removed
pr/external
stage/needs-triage
qingchm
reviewed
Jun 7, 2022
qingchm
reviewed
Jun 7, 2022
qingchm
approved these changes
Jun 8, 2022
Contributor
qingchm
left a comment
qingchm
left a comment
There was a problem hiding this comment.
LGTM! Good job on following up with comments and drafting the PR!
mndeveci
added a commit
that referenced
this pull request
Jun 9, 2022
mndeveci
added a commit
that referenced
this pull request
Jun 13, 2022
mndeveci
added a commit
that referenced
this pull request
Jun 13, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#3246
Why is this change necessary?
Adding S3 bucket options will provide the ability to delete S3 buckets and objects if the bucket and prefix cannot be obtained from the local config file or CloudFormation template.
How does it address the issue?
This change adds the
--s3-bucketand--s3-prefixcommand line options tosam delete.What side effects does this change have?
This change adds additional parameters to
sam deleterelated components.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.