Skip to content

Conversation

@dmarinuswoodwing
Copy link
Contributor

@dmarinuswoodwing dmarinuswoodwing commented May 31, 2022

Which issue(s) does this change fix?

#3791
#3792

Why is this change necessary?

Some python package managers (poetry) aren't able to upgrade flask to the latest supported version:

See: python-poetry/poetry#5728

older versions of flask are broken.

How does it address the issue?

update the minimal version for flask to a working one

What side effects does this change have?

users are required to update flask

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels May 31, 2022
@dmarinuswoodwing dmarinuswoodwing changed the title require Flask 1.1.4 Require Flask 1.1.4 May 31, 2022
@moelasmar
Copy link
Contributor

Thanks @dmarinuswoodwing for raising this PR. I just need to know did you face this issue when you try to use the suggested ways to install SAM CLI here

@dmarinuswoodwing
Copy link
Contributor Author

Hi @moelasmar ! No, I think this only happens when you install SAM CLI from https://pypi.org/project/aws-sam-cli/ (See pip install aws-sam-cli at the top) together with other Python packages (in our case moto).

@moelasmar
Copy link
Contributor

Thanks @dmarinuswoodwing for your reply. I just want to let you know that this way of installation is not preferred, and we prefer to follow one of the installation steps provided here to avoid these type of issues.

@moelasmar moelasmar added blocked/close-if-inactive Blocked for >14 days with no response, will be closed if still inactive after 7 days and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jun 3, 2022
@imduchy
Copy link

imduchy commented Jun 13, 2022

@moelasmar what is the status of this PR? I see you added blocked/close-if-inactive label—is there something missing before it can be merged?

@dmarinuswoodwing
Copy link
Contributor Author

@moelasmar I'm pretty sure the installer would also break when jinja2, werkzeug or itsdangerous get updated which is allowed by flask 1.1.2.

@hawflau hawflau merged commit 6662242 into aws:develop Jun 14, 2022
@dmarinuswoodwing dmarinuswoodwing deleted the Flask-1.1.4 branch June 15, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked/close-if-inactive Blocked for >14 days with no response, will be closed if still inactive after 7 days pr/external

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants