-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Require Flask 1.1.4 #3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Flask 1.1.4 #3925
Conversation
|
Thanks @dmarinuswoodwing for raising this PR. I just need to know did you face this issue when you try to use the suggested ways to install SAM CLI here |
|
Hi @moelasmar ! No, I think this only happens when you install SAM CLI from https://pypi.org/project/aws-sam-cli/ (See |
|
Thanks @dmarinuswoodwing for your reply. I just want to let you know that this way of installation is not preferred, and we prefer to follow one of the installation steps provided here to avoid these type of issues. |
|
@moelasmar what is the status of this PR? I see you added |
|
@moelasmar I'm pretty sure the installer would also break when jinja2, werkzeug or itsdangerous get updated which is allowed by flask 1.1.2. |
Which issue(s) does this change fix?
#3791
#3792
Why is this change necessary?
Some python package managers (poetry) aren't able to upgrade flask to the latest supported version:
See: python-poetry/poetry#5728
older versions of flask are broken.
How does it address the issue?
update the minimal version for flask to a working one
What side effects does this change have?
users are required to update flask
Mandatory Checklist
PRs will only be reviewed after checklist is complete
Add input/output type hints to new functions/methodsWrite design document if needed (Do I need to write a design document?)Write/update unit testsWrite/update integration testsWrite/update functional tests if neededmake prpassesmake update-reproducible-reqsif dependencies were changedWrite documentationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.