Skip to content

chore: Add safe teardown for accelerate integration test#3933

Merged
qingchm merged 3 commits intoaws:developfrom
mingkun2020:safe-teardown
Jun 6, 2022
Merged

chore: Add safe teardown for accelerate integration test#3933
qingchm merged 3 commits intoaws:developfrom
mingkun2020:safe-teardown

Conversation

@mingkun2020
Copy link
Contributor

Sync watch and sync infra don't use fixture, so no change there.

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only thing that we need to be careful about is the other PR which also contains some fixes for the sam logs integration tests here #3930.

@mndeveci mndeveci changed the title [feat] Add safe teardown for accelerate integration test chore: Add safe teardown for accelerate integration test Jun 4, 2022
@qingchm qingchm merged commit fe215c9 into aws:develop Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants