chore: Sync code integration test for nested stack#3943
Merged
qingchm merged 10 commits intoaws:developfrom Jun 8, 2022
Merged
chore: Sync code integration test for nested stack#3943qingchm merged 10 commits intoaws:developfrom
qingchm merged 10 commits intoaws:developfrom
Conversation
qingchm
commented
Jun 7, 2022
| self.assertIn("extra_message", lambda_response) | ||
| self.assertEqual(lambda_response.get("message"), "10") | ||
|
|
||
| @pytest.mark.skip(reason="Currently not properly supported") |
Contributor
Author
There was a problem hiding this comment.
After the nested support for code sync on Api and Statemachine is merged, this line will be removed.
qingchm
commented
Jun 7, 2022
| self.assertIn("extra_message", lambda_response) | ||
| self.assertEqual(lambda_response.get("message"), "10") | ||
|
|
||
| @pytest.mark.skip(reason="Currently not properly supported") |
Contributor
Author
There was a problem hiding this comment.
After the nested support for code sync on Api and Statemachine is merged, this line will be removed.
qingchm
commented
Jun 7, 2022
| ignore_errors=True, | ||
| ) | ||
| shutil.copytree( | ||
| self.test_data_path.joinpath("nested").joinpath("after").joinpath("apigateway"), |
Contributor
Author
There was a problem hiding this comment.
Will change this directory to be a location under child stack.
qingchm
commented
Jun 7, 2022
| ignore_errors=True, | ||
| ) | ||
| shutil.copytree( | ||
| self.test_data_path.joinpath("nested").joinpath("after").joinpath("apigateway"), |
Contributor
Author
There was a problem hiding this comment.
Will change this directory to be a location under child stack.
mingkun2020
reviewed
Jun 7, 2022
| "body": json.dumps({ | ||
| "message": f"{layer_method()+6}", | ||
| "location": ip.text.replace("\n", "") | ||
| # "extra_message": np.array([1, 2, 3, 4, 5, 6]).tolist() # checking external library call will succeed |
Contributor
There was a problem hiding this comment.
Could we remove this line and the numpy import as weel since we are not used.
mildaniel
approved these changes
Jun 8, 2022
mingkun2020
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N.A.
Why is this change necessary?
To add integration test on nested stack support on code sync.
How does it address the issue?
By adding in nested stack test cases.
What side effects does this change have?
Not known.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.