Skip to content

Conversation

@mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jun 9, 2022

Which issue(s) does this change fix?

#3945

Why is this change necessary?

We recently introduced a fix; sam sync will not create dependency layers for functions which doesn't any dependency defined in them. This feature works during initial infra sync but it fails subsequent sync flow executions.

How does it address the issue?

Revert that latest change for now and revert back to original behavior.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qingchm qingchm enabled auto-merge (squash) June 10, 2022 05:26
@qingchm qingchm merged commit 9245fb9 into aws:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants