Skip to content

chore: sam sync & sam logs ux changes#3953

Merged
mndeveci merged 19 commits intoaws:developfrom
mndeveci:accelerate_ux_changes
Jun 10, 2022
Merged

chore: sam sync & sam logs ux changes#3953
mndeveci merged 19 commits intoaws:developfrom
mndeveci:accelerate_ux_changes

Conversation

@mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jun 9, 2022

Following UX changes have been included;

  • S3 bucket location and capabilities are not printed at the beginning of sam sync command since it is already printed later.
  • During the build operation, UUIDs of the build definitions are replaced by the list of resource logical ids.
  • Experimental warning color have changed to yellow.
  • sam logs warning message regarding to missing SFN logging configuration is fixed
  • sam logs error handling improvements
    • Proper error messaging is printed when no region is configured
    • Proper error messaging is printed when user token is expired
    • If --stack-name and --cw-log-group is not provided, error message shown that at least one of them is required.
    • Invalid --stack-name is handled with error messaging
    • Invalid CloudWatch log group or resource logical id (--name) values are added as warning message

Which issue(s) does this change fix?

N/A

Why is this change necessary?

To improve user experience with sam sync and sam logs commands.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/build sam build command area/deploy sam deploy command area/logs sam logs command area/sync sam sync command pr/internal labels Jun 9, 2022
@mndeveci mndeveci merged commit 06d31fc into aws:develop Jun 10, 2022
@mndeveci mndeveci deleted the accelerate_ux_changes branch June 10, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command area/deploy sam deploy command area/logs sam logs command area/sync sam sync command pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants