chore: sam sync & sam logs ux changes#3953
Merged
mndeveci merged 19 commits intoaws:developfrom Jun 10, 2022
Merged
Conversation
mndeveci
commented
Jun 9, 2022
mndeveci
commented
Jun 9, 2022
mndeveci
commented
Jun 9, 2022
mndeveci
commented
Jun 9, 2022
mndeveci
commented
Jun 9, 2022
mingkun2020
approved these changes
Jun 10, 2022
mildaniel
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following UX changes have been included;
sam synccommand since it is already printed later.sam logswarning message regarding to missing SFN logging configuration is fixedsam logserror handling improvements--stack-nameand--cw-log-groupis not provided, error message shown that at least one of them is required.--stack-nameis handled with error messaging--name) values are added as warning messageWhich issue(s) does this change fix?
N/A
Why is this change necessary?
To improve user experience with
sam syncandsam logscommands.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.