fix issue with content-type being overwritten#429
Closed
jameselkins wants to merge 1 commit intoaws:developfrom
atlas-health:je/fix_header_lowercase_issue
Closed
fix issue with content-type being overwritten#429jameselkins wants to merge 1 commit intoaws:developfrom atlas-health:je/fix_header_lowercase_issue
jameselkins wants to merge 1 commit intoaws:developfrom
atlas-health:je/fix_header_lowercase_issue
Conversation
…ose and uppercases the Content-Type header appropriately
Contributor
|
Please follow the Closing as this was already addressed and merged in #398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into issues where an express server, imported using https://github.com/awslabs/aws-serverless-express/tree/master/example and using custom middleware was returning header names in lowercase. This is valid according to the spec: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 and so aws-sam-cli should not force servers to use a capitalized header name (i.e.
content-typeis as good asContent-Type.The issues were that a
content-typeoftext/htmlwas being returned, but aws-sam-cli would replace it withapplication/json.Description of changes:
sometimes servers return headers keys in lowercase. This looks for those and uppercases the Content-Type header appropriately
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.