Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
Since we introduced
ruamel
as a dependency, runningmake pr
fails every other time because of an issue inmypy
E.g.:
Issue in
mypy
:How does it address the issue?
Apply
--no-incredental
as a workaround to not use mypy's cachcing mechanism. So it doesn't hit the error.What side effects does this change have?
mypy
/make lint
could run slower since it forces mypy to not use caching.Note that in our CI/CD jobs,
mypy
is run only once. So we won't have any issue in our CI/CD jobs.This change helps smoothing the local dev experience a bit because mypy fixes the issue.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.