Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Runtime management controls (#420) #4609

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jan 24, 2023

  • Modify ECR repo from /sam/emulation-<runtime> to /lambda/<runtime>.
  • Keep RAPID image up-to-date with the remote environment.
  • Remove SAM cli version from RAPID image tag locally.
    • These modifications change the rapid image tag
      from python3.7-rapid-1.2.0-x86_64 to 3.7-rapid-x86_64,
      since now the runtime name is part of the image name and not the tag.
  • Support a RuntimeManagementConfig in SAM templates and show a message
    if a runtime version is pinned in the template when invoking.
  • Rename some variables when building the rapid image, for more clarity in the code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feat: Support Runtime management controls

- Modify ECR repo from `/sam/emulation-<runtime>` to `/lambda/<runtime>`.
- Keep RAPID image up-to-date with the remote environment.
- Remove SAM cli version from RAPID image tag locally.
  - These modifications change the rapid image tag
    from `python3.7-rapid-1.2.0-x86_64` to `3.7-rapid-x86_64`,
    since now the runtime name is part of the image *name* and not the tag.
- Support a `RuntimeManagementConfig` in SAM templates and show a message
  if a runtime version is pinned in the template when invoking.
- Rename some variables when building the rapid image, for more clarity.

* PR feedback. Add placeholder text

* Last updates for RuntimeManagementConfiguration

- Change from RuntimeVersion to RuntimeVersion Arn
- Update the message when user has a RuntimeVersion in their template
and wants to invoke locally.

* Update with latest tranform changes

* update tests with latest transform changes

* rollback dev version of SAMT

Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
@mndeveci mndeveci requested a review from a team as a code owner January 24, 2023 00:13
@mndeveci mndeveci requested review from lucashuy and jfuss January 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants