Skip to content

fix: fix the hardcoded number of stages printed in logs. #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moelasmar merged 1 commit into from
May 27, 2023
Merged

fix: fix the hardcoded number of stages printed in logs. #5210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samcli/commands/pipeline/init/interactive_init_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def _generate_from_pipeline_template(
continue
click.echo(
Colored().yellow(
"2 stage(s) were detected, matching the template requirements. "
f"{number_of_stages} stage(s) were detected, matching the template requirements. "
Copy link
Contributor

@mndeveci mndeveci May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update existing unit tests to confirm this message from now on?

Copy link
Contributor Author

@moelasmar moelasmar May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check the existing unit test cases.

"If these are incorrect, delete .aws-sam/pipeline/pipelineconfig.toml and rerun"
)
)
Expand Down