fix: handle edge cases with function sync flow in sam sync command #5222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
commented
May 31, 2023
|
|
||
| resource_collector.add_layer(layer) | ||
|
|
||
| @staticmethod |
Contributor
Author
There was a problem hiding this comment.
This functionality is moved to Function class and FunctionBuildInfo enum below.
hnnasit
reviewed
May 31, 2023
Contributor
hnnasit
left a comment
hnnasit
left a comment
There was a problem hiding this comment.
Overall LGTM, left some small comments.
jfuss
approved these changes
May 31, 2023
hnnasit
approved these changes
May 31, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#5034
Why is this change necessary?
When customers provide pre-built ZIP file for their functions,
sam syncwould fail since it always tries to build the function. Same happens when customers denote their functions withSkipBuild: true.How does it address the issue?
When creating
ZipFunctionSyncFlow, it checks whether function'sCodeUriis pointing to a.zipfile, or it hasSkipBuild: Truein function metadata. If so then it instantiates different sync flows.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.