Skip to content

Conversation

@lucashuy
Copy link
Contributor

@lucashuy lucashuy commented May 30, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Gateway Methods can contain a reference to a Lambda Authorizer, we'll need to resolve the link between the two.

How does it address the issue?

Links the AuthorizerId property in the CFN resource to the right Authorizer using either a Ref or a existing value.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review May 31, 2023 00:12
@lucashuy lucashuy requested a review from a team as a code owner May 31, 2023 00:12
@lucashuy lucashuy requested review from hnnasit and moelasmar May 31, 2023 00:12
@lucashuy lucashuy added this pull request to the merge queue May 31, 2023
@lucashuy lucashuy removed this pull request from the merge queue due to a manual request May 31, 2023
@lucashuy lucashuy added this pull request to the merge queue May 31, 2023
Merged via the queue into aws:develop with commit 2e79b50 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants