Skip to content

Conversation

@mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions bot and others added 6 commits June 16, 2023 00:16
Co-authored-by: GitHub Action <action@github.com>
* Improve remote invoke help text and fix some UX bugs

* Updated help text for parameter option

* Updated test class name

* Updated test method name

* Updated help text for output-format and event-file

* Address feedback

* Updated help text for parameter option

* Changed --output-format name to output and the values to text/json

* Handle empty event for lambda and read from stdin when - is passed for event-file
* chore: temporary pin python version to 3.7.16

* fix github action syntax error
* Remove unneeded test cases

* Removing the two integ test cases as there is already coverage in unit test for cases that no region is specified
@mildaniel mildaniel requested a review from a team as a code owner June 20, 2023 23:19
@mildaniel mildaniel requested review from jfuss and moelasmar June 20, 2023 23:19
@mildaniel mildaniel enabled auto-merge (squash) June 20, 2023 23:42
@mildaniel mildaniel merged commit 93979d9 into aws:feat/terraform-start-api Jun 21, 2023
@mildaniel mildaniel deleted the merge-develop-into-start-api branch June 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants