feat: Disable samconfig.json support

samcli/lib/config/file_manager.py

@@ -338,5 +338,5 @@ def put_comment(document: Any, comment: str) -> Any:
     ".toml": TomlFileManager,
     ".yaml": YamlFileManager,
     ".yml": YamlFileManager,
-    ".json": JsonFileManager,
+    # ".json": JsonFileManager,  # JSON support disabled
 }

tests/integration/buildcmd/test_build_samconfig.py

@@ -9,6 +9,7 @@
 configs = {
     ".toml": "samconfig/samconfig.toml",
     ".yaml": "samconfig/samconfig.yaml",
+    ".yml": "samconfig/samconfig.yml",
     ".json": "samconfig/samconfig.json",
 }
 
@@ -18,7 +19,7 @@ class TestSamConfigWithBuild(BuildIntegBase):
         [
             (".toml"),
             (".yaml"),
-            (".json"),
+            # (".json"),
         ]
     )
     def test_samconfig_works_with_extension(self, extension):
@@ -40,7 +41,7 @@ def test_samconfig_works_with_extension(self, extension):
         [
             (".toml"),
             (".yaml"),
-            (".json"),
+            # (".json"),
         ]
     )
     def test_samconfig_parameters_are_overridden(self, extension):
@@ -72,8 +73,8 @@ def test_samconfig_parameters_are_overridden(self, extension):
 
 @parameterized_class(
     [  # Ordered by expected priority
-        {"extensions": [".toml", ".yaml", ".json"]},
-        {"extensions": [".yaml", ".json"]},
+        {"extensions": [".toml", ".yaml", ".yml"]},
+        {"extensions": [".yaml", ".yml"]},
     ]
 )
 class TestSamConfigExtensionHierarchy(BuildIntegBase):

tests/integration/testdata/buildcmd/samconfig/samconfig.yml

@@ -0,0 +1,7 @@
+version: 0.1
+default:
+  build:
+    parameters:
+      build_dir: .yml
+      cached: true
+      parameter_overrides: Runtime=python3.9 CodeUri=SomeURI Handler=SomeHandler

tests/unit/lib/samconfig/test_file_manager.py

@@ -1,7 +1,7 @@
 import json
 from pathlib import Path
 import tempfile
-from unittest import TestCase
+from unittest import TestCase, skip
 
 import tomlkit
 from ruamel.yaml import YAML
@@ -182,6 +182,7 @@ def test_yaml_put_comment(self):
         self.assertIn("# This is a comment", txt)
 
 
+@skip("JSON config support disabled")
 class TestJsonFileManager(TestCase):
     def test_read_json(self):
         config_dir = tempfile.gettempdir()

tests/unit/lib/samconfig/test_samconfig.py

@@ -295,7 +295,7 @@ def test_file_manager_unsupported(self):
             ("samconfig.toml", TomlFileManager, ".toml"),
             ("samconfig.yaml", YamlFileManager, ".yaml"),
             ("samconfig.yml", YamlFileManager, ".yml"),
-            ("samconfig.json", JsonFileManager, ".json"),
+            # ("samconfig.json", JsonFileManager, ".json"),
         ]
     )
     @patch("samcli.lib.telemetry.event.EventTracker.track_event")