Skip to content

add pip check after all pip install in pyinstaller scripts #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hawflau merged 2 commits into from
Jul 7, 2023
Merged

add pip check after all pip install in pyinstaller scripts #5463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47e08b
add pip check after all pip install in pyinstaller scripts
hawflau Jul 7, 2023
ef8dc60
update pyinstaller build scripts to explicitly print executed commands
hawflau Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion installer/pyinstaller/build-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ else
is_nightly="false"
fi

set -eu
set -eux

yum install -y zlib-devel libffi-devel bzip2-devel

Expand Down Expand Up @@ -83,6 +83,7 @@ cp -r ./venv/lib/python*/site-packages/* ./output/python-libraries

echo "Installing PyInstaller"
./venv/bin/pip install -r src/requirements/pyinstaller-build.txt
./venv/bin/pip check

echo "Building Binary"
cd src
Expand Down
3 changes: 2 additions & 1 deletion installer/pyinstaller/build-mac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ else
is_nightly="false"
fi

set -eu
set -eux

echo "Making Folders"
mkdir -p .build/src
Expand Down Expand Up @@ -93,6 +93,7 @@ cp -r ./venv/lib/python*/site-packages/* ./output/python-libraries

echo "Installing PyInstaller"
./venv/bin/pip install -r src/requirements/pyinstaller-build.txt
./venv/bin/pip check

# Building the binary using pyinstaller
echo "Building Binary"
Expand Down