feat: Add unit testing to JSON schema#5593
Merged
lucashuy merged 8 commits intoaws:feat/json-schemafrom Jul 24, 2023
Merged
Conversation
github-actions
bot
added
pr/external
stage/needs-triage
lucashuy
reviewed
Jul 21, 2023
hnnasit
approved these changes
Jul 24, 2023
Contributor
hnnasit
left a comment
hnnasit
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Contributor
|
Could we also add the schema folder to the Makefile testing related targets so that they also get run by |
lucashuy
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
The generation logic of the JSON schema must be proven to be correct, which is why its methods should be unit tested.
How does it address the issue?
Unit tests have been added for all of the methods in
schema.py, ensuring that they are correct and complete.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.