Skip to content

feat: Generate sam sync schema#5612

Merged
lucashuy merged 2 commits intoaws:feat/json-schemafrom
Leo10Gama:sync-schema
Jul 25, 2023
Merged

feat: Generate sam sync schema#5612
lucashuy merged 2 commits intoaws:feat/json-schemafrom
Leo10Gama:sync-schema

Conversation

@Leo10Gama
Copy link
Contributor

With this change, the schema for sam sync will be added to the JSON schema. It will serve to validate the parameters in samconfig for the sync command.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 25, 2023 16:50
@Leo10Gama Leo10Gama requested review from hnnasit and moelasmar July 25, 2023 16:50
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 25, 2023
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucashuy lucashuy enabled auto-merge (squash) July 25, 2023 20:27
@lucashuy lucashuy disabled auto-merge July 25, 2023 20:28
@lucashuy lucashuy merged commit f135a69 into aws:feat/json-schema Jul 25, 2023
@Leo10Gama Leo10Gama deleted the sync-schema branch July 25, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants