chore: fix running root GHA job all the time #6203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our branch protection rules has a root job called
PR Workflowwhich depends on all other Github Actions that we have and reports a success or failure depending on them.However this configuration doesn't work if any job fails since it will cause this
PR Workflowjob to be skipped and GH will merge the PR in that case.This change adds a condition to the
PR Workflowwhich will force to runPR Workfloweven though the others have failed.Example run before adding the condition: #6219
Even though some CI checks have failed, GH still merged the PR. We can see that
PR Workflowwas skipped for this instance.Example run after applying the suggested solution: #6220
This PR was blocked from merging and we can validate that it ran the
PR Workflow(didn't skip it)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.