-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cookiecutter URL to point at correct github repo #692
Conversation
@stealthycoin These are not the same repos. The one you have changed to is an advanced python example and not the hello world one that is in the repo. The cookiecutter parts of this README do not make sense to me, since they will be created through SAM CLI. @heitorlessa Why is the README saying to use cookiecutter instead of SAM CLI? |
In any case the one I was changing it from is a 404: https://github.com/aws-samples/cookiecutter-aws-sam-hello-python. Someone else had reported that the SAM CLI when used to run the template didn't set up the testing requirements properly (pytest etc) so I was trying out the cookiecutter template directly to see if it generated them. If it was actually a different template that I wound up running, it would make sense why it had the test dependencies declared and the other one didn't. |
That github doesn't exist and we should fix this doc but we can't change that reference the one you have since it is completely different. My point is that I think we should just remove those lines you changed but wanted to understand why it is the way it is now before moving forward. |
@jfuss This is an unpaid tech debt. README comes from unpublished repo before sam init was created; we're creating dedicated repo for each runtime as initially intended and moving these outside this repo. What customers should be reading today is not this README but the README that is generated as part of the template as these are raw files. |
@heitorlessa That doesn't mean we should keep it either though. If it does not provide any value, we should just remove it. Thoughts? |
I agree on removing it as it only confuses those who look up at the source
thinking this would provide any value
…On Wed, 10 Oct 2018 at 15:12, Jacob Fuss ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> That doesn't mean we should
keep it either though. If it does not provide any value, we should just
remove it. Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#692 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADL4BPkQ0gZXM4F7d1O4Mw-ym6bVsA1Hks5ujfIagaJpZM4XIm8u>
.
|
@heitorlessa Are you talking these types of things in with your rework of all the init examples? Do we still need this if that is the case? |
Yes Jacob, I’m tackling those there too.
New root READMEs (cookiecutter not project) has this reflected and this can
be closed after merge
…On Tue, 8 Jan 2019 at 16:07, Jacob Fuss ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> Are you talking these types
of things in with your rework of all the init examples? Do we still need
this if that is the case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#692 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADL4BKfSM9AwgFrrE-v5zD9i1pkH5yoJks5vBMJWgaJpZM4XIm8u>
.
|
@stealthycoin Thanks for the PR. We addressed this in a different PR (#849) while redoing some of the init examples. Closing this as it is no longer needed. |
Removed the
hello
in the github reference since that repo does not exist.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.