Request for Comments: Debugging dotnetcore Lambda Functions #759
Conversation
sanathkr
changed the title
designs/dotnetcore-debugging.md
Outdated
| _From SAM code - container.py:_ | ||
|
|
||
| ```python | ||
| for frame_type, data in output_itr: |
There was a problem hiding this comment.
Yeah, I believe this : #729
We do have unbuffered streams, whenever a debug port is set explicitly. but in this case there is no debugger port. because of the .net debugging works here, so we may need to slightly rethink that.
There was a problem hiding this comment.
Actually the port is set, and environment variable is set as expected, but it just won't work on python 3.7
designs/dotnetcore-debugging.md
Outdated
| As you see above with flush, everything works. Without it all is buffered, help needed, maybe this [link](https://docs.python.org/3/using/cmdline.html#cmdoption-u) will give something (see note for python 3.7), | ||
|
|
||
| 3. Help needed in investigation of how to adopt that approach for VS 2017. See this [link](https://github.com/Microsoft/MIEngine/wiki/Offroad-Debugging-of-.NET-Core-on-Linux---OSX-from-Visual-Studio) for some information. Maybe we can try to use Docker as a pipe there too. | ||
| 4. Docker in VS Code reports _"The pipe program 'docker' exited unexpectedly with code 137."_ after stopping or hitting continue which leads to quitting the program. It seems, that 137 is **killed** exit code, which seems a bit strange, maybe you guys, have some ideas on that? Haven't investigated yet. |
There was a problem hiding this comment.
This is strange and definitely needs to be investigated.
There was a problem hiding this comment.
Maybe I've described a bit incorrectly (so a bit of clarification), the debugging process works fine and smooth, but as soon as it ends, VS Code just shows the notification, it is just annoying, but the functionality works just fine.
ndobryanskyy
changed the title
|
|
||
| ### What is the problem | ||
|
|
||
| Currently SAM CLI does not provide debugging support for .NET Core 2.0 and 2.1 because `dotnet` command does **not** support _start and wait for the debugger_ configuration out of the box and neither does current AWS Lambda runner ([2.0](https://github.com/lambci/docker-lambda/tree/master/dotnetcore2.0) / [2.1](https://github.com/lambci/docker-lambda/tree/master/dotnetcore2.1)) has debugging support flag or anything. |
There was a problem hiding this comment.
There is some talk here that it might make it to 3.0
https://github.com/dotnet/core-setup/issues/198
There was a problem hiding this comment.
Yes, I've mentioned this issue in the document too. But I don't think it has some priority there now
designs/dotnetcore-debugging.md
Outdated
|
|
||
| Visual Studio 2017 (can be a target, but it has some other very different Docker container debugging support - needs additional investigation). But some trick with `launch.json` [might be possible](https://github.com/Microsoft/MIEngine/wiki/Offroad-Debugging-of-.NET-Core-on-Linux---OSX-from-Visual-Studio). Help on this area is highly appreciated. | ||
|
|
||
| Rider support also needs separate investigation, as it does not support `vsdbg` by any means (licensing [issue](https://github.com/dotnet/core/issues/505)) and therefore they have [their own](https://blog.jetbrains.com/dotnet/2017/02/23/rider-eap-18-coreclr-debugging-back-windows/) debugger implementation and possibly UX around .NET Core remote debugging. If support is required - I think we should open another issue. |
There was a problem hiding this comment.
Rider may be using a ssh based transport, so we need to be extensible of adding that.
There was a problem hiding this comment.
The worst thing, is that they are not using vsdbg 😞 because of the licensing
|
|
||
| ### CLI Changes | ||
|
|
||
| None required. We would happily use `debugger_port` and `debugger_path` like other runtimes. |
… dotnetcore-debugging-design
…ryanskyy/aws-sam-cli into dotnetcore-debugging-design
Original Issue
#568 - Feature request
Design document
⚡ Rendered document is available here
Doc is updated and utilizes new
docker psfilter approach. @jfuss, @thesriram, please take a look on it and my updated POC -as always comments and questions are welcome!If you are okay with the new approach, the only thing left is merging PR to
lamci/lambda.As requested I provide design document and example which uses modified runner from PR which I would also appreciate reviewing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.