Skip to content

fix: Stop html encoding of options for generate-event#824

Merged
jfuss merged 2 commits intoaws:developfrom
jfuss:non-html-encode-events
Dec 5, 2018
Merged

fix: Stop html encoding of options for generate-event#824
jfuss merged 2 commits intoaws:developfrom
jfuss:non-html-encode-events

Conversation

@jfuss
Copy link
Contributor

@jfuss jfuss commented Dec 3, 2018

In mustache all variables ({{name}}) are HTML escaped, which is not what we want
for the generate-event command. To force unescaped HTML, you need to use the
triple mustache: {{{name}}}

Issue #, if available:
#755

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In mustache all variables ({{name}}) are HTML escaped, which is not what we want
for the generate-event command. To force unescaped HTML, you need to use the
triple mustache: {{{name}}}
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very nice catch!

@jfuss jfuss merged commit 1e8bd0b into aws:develop Dec 5, 2018
willyg302 added a commit to willyg302/aws-sam-cli that referenced this pull request Aug 30, 2019
Everything switched to triple mustache in aws#824 except for these two
occurrences.
sanathkr pushed a commit that referenced this pull request Aug 30, 2019
…1389)

Everything switched to triple mustache in #824 except for these two
occurrences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants