Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump up serverlessrepo version #892

Closed
wants to merge 1 commit into from

Conversation

paoptu023
Copy link
Contributor

Issue #, if available:
amazon-archives/aws-serverlessrepo-python#21

Description of changes:
serverlessrepo added support for Python 3.4 and 3.5 in version 0.1.6.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss
Copy link
Contributor

jfuss commented Dec 27, 2018

@paoptu023 Is this the only change? #891 is fixing our support.

@paoptu023
Copy link
Contributor Author

Yeah this is the only change.

@jfuss
Copy link
Contributor

jfuss commented Dec 27, 2018

If that is the case, I am not inclined to add this version. SAM CLI does not support 3.5 or 3.4 and is being addressed in #891. It looks like we have had an issue with this not correctly working in PyPi for a while :( but isn't supported.

@jfuss
Copy link
Contributor

jfuss commented Dec 27, 2018

Closing since the only change is Python support and for Python version SAM CLI does not support.

@jfuss jfuss closed this Dec 27, 2018
@paoptu023 paoptu023 deleted the serverlessrepo branch January 10, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants