Update the sam cli example in the nodejs template README.md #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Release v0.8.0
chore: v0.8.1 Release
chore: Release v0.9.0
chore: Release v0.10.0
Remove --template-file option from sam package example in the nodejs template README.md This corrects a problem where the node_modules folder was not included in the package artifact deployed to s3
|
@greensopinion Thanks for doing this. I didn't realize this was also being addressed in #849 at the time. Since that had this fix as well, I am going to close this PR. |
|
ok, thanks for the heads-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #908:
Description of changes:
Remove
--template-fileoption fromsam packageexample in the nodejs template README.mdThis corrects a problem where the node_modules folder was not included in the package artifact deployed to s3.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.