Skip to content

fix(layers): show warning if !Sub function is used in Layers section of template.yaml (#948) #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goldeneggg wants to merge 2 commits into from
Closed

fix(layers): show warning if !Sub function is used in Layers section of template.yaml (#948) #949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1281ca
fix(layers): show warning if `!Sub` function is used in `Layers` sect…
goldeneggg Jan 19, 2019
00af3c3
fix message
goldeneggg Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions samcli/commands/local/lib/sam_function_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,11 @@ def _parse_layer_info(list_of_layers, resources):
"""
layers = []
for layer in list_of_layers:
if isinstance(layer, dict) and layer.get("Fn::Sub"):
LOG.warning("'!Sub' keyword in Layer configuration does not work at local. "
"Please replace all parameter strings(like '${AWS::Region}') with the original value "
"and remove '!Sub' keyword from template.yaml .")

# If the layer is a string, assume it is the arn
if isinstance(layer, six.string_types):
layers.append(LayerVersion(layer, None))
Expand Down