Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building with MinGW #1333

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

trilader
Copy link

@trilader trilader commented Mar 3, 2020

Issue #, if available:

Description of changes:
This PR adds support for building aws-sdk-cpp with the MinGW toolchain on Windows.
Needs awslabs/aws-c-common#604 in order to work.

The main changes are adding checks for the MINGW32 define which is preset on both 32 and 64 bit MinGW installations, silencing some bogus warnings and addressing some 0 vs NULL cases which gcc complains about.

I don't this this needs explicit tests but might need additional CI work to ensure MinGW continues to work in the future.
Regarding ReadMe/Wiki: It might need mentioning that building with MinGW is supported.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trilader trilader marked this pull request as ready for review March 5, 2020 10:15
@KaibaLopez KaibaLopez added the pr/needs-review This PR needs a review from a Member. label Apr 1, 2020
@ihnorton ihnorton mentioned this pull request Aug 6, 2020
@jeroen
Copy link

jeroen commented Aug 15, 2020

FYI, we have adopted a modified version of this patch in msys2 mingw-w64-aws-sdk-cpp. To install binaries from msys2 use

pacman -Syu
pacman -S mingw-w64-{i686,x86_64}-aws-sdk-cpp

@jmklix jmklix removed the request for review from wps132230 September 9, 2022 18:16
@jmklix jmklix added needs-review This issue or pull request needs review from a core team member. and removed pr/needs-review This PR needs a review from a Member. labels Jan 27, 2023
@jmklix
Copy link
Member

jmklix commented Jul 19, 2023

Thanks for taking the time to make this PR. We are still interested in adding MinGW support for this sdk, but the implementation will need to be changed slightly and this isn't a high priority currently. Also we will have to add CI so this isn't broken in with any future releases. Because of this I will be converting this PR to a draft.

@jmklix jmklix marked this pull request as draft July 19, 2023 23:47
@jmklix jmklix removed the needs-review This issue or pull request needs review from a core team member. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants