Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings #2944

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix warnings #2944

wants to merge 3 commits into from

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Apr 29, 2024

Issue #, if available:
#2363

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -39,7 +39,7 @@ namespace Aws
AWS_UNREFERENCED_PARAM(AMZN_XML_CONTENT_TYPE);
}

virtual ~AmazonSerializableWebServiceRequest() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space before braces. do we actually need braces in this case at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there currently is no consistency with having or not having the empty {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I remove all of them

@@ -128,6 +128,71 @@ namespace Aws
return true;
default:
return false;
case HttpResponseCode::REQUEST_NOT_MADE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the actual warning? id rather not list all enum values if possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this:

warning: 15 enumeration values not explicitly handled in switch: 'AWS_MQTT5_PT_RESERVED', 'AWS_MQTT5_PT_CONNECT', 'AWS_MQTT5_PT_CONNACK'..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants