Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error for older gcc #3220

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix compilation error for older gcc #3220

wants to merge 4 commits into from

Conversation

sbera87
Copy link
Contributor

@sbera87 sbera87 commented Dec 11, 2024

Issue #, if available:

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbera87 sbera87 changed the title Fix compilation error for older gcc (Work in Progress) Fix compilation error for older gcc Dec 11, 2024
@@ -91,11 +91,10 @@ namespace Aws

protected:
const Aws::Utils::Json::JsonValue& GetJsonPayloadFromError(const AWSError<CoreErrors>&) const;
AWSError<CoreErrors> MarshallHelper(const Aws::String& exceptionName, const Aws::String& message) const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so something i cant help but notice is that that JsonErrorMarshallerQueryCompatible::Marshall and JsonErrorMarshaller::Marshall are more or less copy and pasted code, which is why you have to invoke the parent class of JsonErrorMarshaller. instead we should try to make this more DRY and not have copy and pasted code and this eliminates the need for the child class to access the parents class, parent class. i.e. we could make a inherited callback.

struct Error{};
struct Response{};

class JsonSerializer {
public:
  Error Marshall(Response response) {
    auto error = ParseResponse(response);
    inheritedCallbacks(error, response);
    return error;
  }

protected:
  std::function<void(Error& error, Response& response)> inheritedCallbacks{};
private:
  Error ParseResponse(Response response);
};

class JsonQueryCompatible : public JsonSerializer {
public:
  JsonQueryCompatible() {
    inheritedCallbacks = [](Error& error, Response& response) {
      //custom error parsing
    };
  }
}

this way we avoid parsing something twice, and we contain the new code to ONLY be the bit about query compatible traits

@SergeyRyabinin SergeyRyabinin self-requested a review December 11, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants