Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid double read from steam from curl when stream is small #3222

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Fixes a corner case in aws chunked streaming that lead to performance problems. we recently fixed a bug in aws chunked streaming that fixed it in curl. There was however a performance oversight. on a chunk less that the default chunk size, it would require two stream reads from curl instead of one. requiring two stream reads increased latency very slightly for smaller objects.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbera87 sbera87 self-requested a review December 12, 2024 17:36
Copy link
Contributor

@sbera87 sbera87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbiscigl sbiscigl marked this pull request as ready for review December 13, 2024 16:18
@sbiscigl sbiscigl merged commit 54b0a4c into main Dec 13, 2024
5 checks passed
@sbiscigl sbiscigl deleted the perf-fix branch December 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants