Skip to content

Conversation

sbiscigl
Copy link
Contributor

Issue #, if available:

#3524

Description of changes:

fixes honoring the overriden user agent string if configured on client configuration

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kai-ion kai-ion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbiscigl sbiscigl force-pushed the fix-ua-override branch 2 times, most recently from b3b7321 to aaab8e2 Compare August 27, 2025 21:25
@sbiscigl sbiscigl marked this pull request as ready for review August 28, 2025 13:41
@sbiscigl sbiscigl force-pushed the fix-ua-override branch 4 times, most recently from 3eba1fa to edc7607 Compare August 28, 2025 20:01
@sbiscigl sbiscigl merged commit 891e294 into main Aug 29, 2025
5 of 6 checks passed
@sbiscigl sbiscigl deleted the fix-ua-override branch August 29, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants