[C++] SDKs to track feature Ids for Credentials (SSO/LegacySSO Provider) #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kai-ion
changed the title
kai-ion
changed the title
# Conflicts: # src/aws-cpp-sdk-core/include/aws/core/client/UserAgent.h # src/aws-cpp-sdk-core/source/auth/AWSCredentialsProvider.cpp # src/aws-cpp-sdk-core/source/client/UserAgent.cpp # tests/aws-cpp-sdk-core-tests/aws/auth/CredentialTrackingTest.cpp # Conflicts: # tests/aws-cpp-sdk-core-tests/aws/auth/CredentialTrackingTest.cpp
sbiscigl
reviewed
Sep 9, 2025
sbiscigl
reviewed
Sep 10, 2025
| Aws::MakeShared<Aws::Client::AWSAuthV4Signer>(TEST_LOG_TAG, provider, "service", config.region), | ||
| Aws::MakeShared<MockAWSErrorMarshaller>(TEST_LOG_TAG)) {} | ||
|
|
||
| HttpResponseOutcome MakeRequest(const Aws::AmazonWebServiceRequest& request) { |
There was a problem hiding this comment.
this is sort of weird, we shouldnt be subclassing AwsClient and then creating a function as a entry point, we should make a real aws client and be testing that object. make a mock aws client like we do in the RDS unit test. but not RDS specific and invoke the public functions on AWS client.
| AwsCppSdkGTestSuite::SetUp(); | ||
|
|
||
| // Build paths the same way the SDK does | ||
| const Aws::String profileDir = ProfileConfigFileAWSCredentialsProvider::GetProfileDirectory(); |
There was a problem hiding this comment.
if this ran in on a users machine would this overrite their SSO configuraiton if it existed? If so we need to have this existing in a temp file/temp directory as we do in other tests. we cant mess with use credentials if its building on a users machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implement User-Agent 2.1 business metrics for credential provider tracking in AWS SDK for C++.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.