Skip to content

Commit

Permalink
Remove api_diff_check CI action due to issue with module hashes (#1164)
Browse files Browse the repository at this point in the history
Removes the api_diff_check GitHub CI action since it was failing due to
the SDK's inconsistent go.sum and go.mod files throughout its various
modules. Until these can be resolved, and gorelease updated to ignore
go.sum files this action needs to be removed.
  • Loading branch information
jasdel authored Mar 10, 2021
1 parent c122f49 commit 7215234
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 30 deletions.
30 changes: 0 additions & 30 deletions .github/workflows/api_diff_check.yml

This file was deleted.

15 changes: 15 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,21 @@ cachedep-modules-%:
&& go run . -p $(subst _,/,$(subst cachedep-modules-,,$@)) ${EACHMODULE_FLAGS} \
"go mod download"

api-diff-modules-%:
@# Command that uses the pattern to define the root path that the
@# module testing will start from. Strips off the "api-diff-modules-" and
@# replaces all "_" with "/".
@#
@# Requires golang.org/x/exp/cmd/gorelease to be available in the GOPATH.
@#
@# e.g. api-diff-modules-internal_protocoltest
cd ./internal/repotools/cmd/eachmodule \
&& go run . -p $(subst _,/,$(subst api-diff-modules-,,$@)) \
-fail-fast=true \
-c 1 \
-skip="internal/repotools" \
"$$(go env GOPATH)/bin/gorelease"

##############
# CI Testing #
##############
Expand Down

0 comments on commit 7215234

Please sign in to comment.