Skip to content

Commit

Permalink
Update hostCompatibleBucketName doc to reflect #848 changes
Browse files Browse the repository at this point in the history
  • Loading branch information
lggomez committed Apr 26, 2022
1 parent 6911981 commit a20bc9a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions service/s3/internal/customizations/update_endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ type UpdateEndpointParameterAccessor struct {

// UpdateEndpointOptions provides the options for the UpdateEndpoint middleware setup.
type UpdateEndpointOptions struct {

// Accessor are parameter accessors used by the middleware
Accessor UpdateEndpointParameterAccessor

Expand Down Expand Up @@ -256,8 +255,9 @@ func removeBucketFromPath(u *url.URL, bucket string) {
}

// hostCompatibleBucketName returns true if the request should
// put the bucket in the host. This is false if S3ForcePathStyle is
// explicitly set or if the bucket is not DNS compatible.
// put the bucket in the host. This is false if the bucket is not
// DNS compatible of if the client has and EndpointResolver with
// its HostnameImmutable property set to true
func hostCompatibleBucketName(u *url.URL, bucket string) bool {
// Bucket might be DNS compatible but dots in the hostname will fail
// certificate validation, so do not use host-style.
Expand Down

0 comments on commit a20bc9a

Please sign in to comment.