Add missing matching event types deliveryDelay and subscription to SES EventDestination

[Jimmy89]

Describe the bug

The EventDestination matchingEventTypes is missing support for two types: deliveryDelay and subscription.

Place where it should be added: https://github.com/aws/aws-sdk-go-v2/blob/main/service/ses/types/types.go#L361-L374

Expected Behavior

I'm using the AWS terraform package to create all my SES event destinations and I noticed that I cannot use the missing two types.

I inserted a ticket (hashicorp/terraform-provider-aws#33983) which lead to this repo.

According to the AWS Cloud Control API and Cloudformation documentation the matching event types for the event destinations exists, so it would be great if they are added.

Cloudformation doc link: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ses-configurationseteventdestination-eventdestination.html#cfn-ses-configurationseteventdestination-eventdestination-matchingeventtypes

Current Behavior

Reproduction Steps

Sorry, I'm not able to provide this, but I hope the description and links are sufficient.

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

Compiler and Version used

Operating System and version

[RanVaknin]

Hi @Jimmy89,

Thanks for the issue. I'm not sure if these values are unique to Cfn but from looking at the model and the service documentation, those types are not listed. My guess is that the service team has rolled those service side but never updated the model from which the SDK is generated.

I created a ticket with the SES service team to further investigate this: P104431082

Please stay tuned.
All the best,
Ran~

[RanVaknin]

Hi @Jimmy89 ,

I heard back from the service team. The fields in question are available in sesv2 API
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_EventDestination.html

Thanks,
Ran~

[github-actions]

This issue has not received a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.

[Jimmy89]

@RanVaknin Thank you for reaching out to the team. I'm sorry but I don't understand whether the SDK (this repo) will start adding these two types on the related lines/code pointed out in the original message. Without that support, Terraform will not be able to use these types.
Are you saying that the sesv2 API is not supported through this repo?

[lucix-aws]

sesv2 is supported - it's a separate service ID and has its own package https://github.com/aws/aws-sdk-go-v2/tree/main/service/sesv2.

Closing since it sounds like there's nothing missing.

EDIT: concerning

whether the SDK (this repo) will start adding these two types on the related lines/code pointed out in the original message

Note that this isn't controlled by us - we just codegen SDKs from smithy models the service teams maintain. It appears in this case that they've chosen to expose a separate "v2" API, hence the split.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.