[Enhancement]: Add matching types deliveryDelay and subscription to SES EventDestination

[Jimmy89]

Description

SES Event destinations have multiple matching types. However, the types deliveryDelay and subscription are not programmed in the resource information of the SES EventDestination terraform resource, while they are available (through CLI/API)

You can find them in the AWS CloudFormation documentation:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ses-configurationseteventdestination-eventdestination.html#cfn-ses-configurationseteventdestination-eventdestination-matchingeventtypes

Affected Resource(s) and/or Data Source(s)

• aws_ses_event_destination (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ses_event_destination)

Potential Terraform Configuration

resource "aws_ses_event_destination" "sns" {
  name                   = "event-destination-sns"
  configuration_set_name = aws_ses_configuration_set.example.name
  enabled                = true
  matching_types         = ["deliveryDelay", "subscription"]

  sns_destination {
    topic_arn = aws_sns_topic.example.arn
  }
}

References

• https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ses-configurationseteventdestination-eventdestination.html#cfn-ses-configurationseteventdestination-eventdestination-matchingeventtypes
• https://www.pulumi.com/registry/packages/aws-native/api-docs/ses/configurationseteventdestination/#matchingeventtypes_nodejs

Would you like to implement a fix?

No

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[danquack]

The types are defined from the sdk. I also don't see it in the v2 sdk, so not sure I migration to v2 would work either. This may require some upstream change?

[Jimmy89]

Thank you @danquack, I created a ticket in the v2 sdk repo (aws/aws-sdk-go-v2#2342)

[Jimmy89]

@danquack AWS has responded to my ticket: aws/aws-sdk-go-v2#2342 (comment)

I hope this helps you

[danquack]

Their response is to use the ses-v2. This particular resource is for ses, I wonder if maybe we need to add this resource to #26796? By chance could you use https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sesv2_configuration_set_event_destination instead?

[Jimmy89]

Unfortunately, I use Pulumi aws (classic) package for all my infra-as-code, which uses the v1 of the ses event destination.
The aws-native package of Pulumi uses AWS Cloud API, which uses v2. However, that one has an active issue (pulumi/pulumi-aws-native#1139) where the resource is created but not registered as one (and therefore my infra-as-code fails)