Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SDK middleware values scoped to the stack being invoked #1019

Merged
merged 5 commits into from
Jan 8, 2021

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jan 6, 2021

Updates the SDK's middleware metadata to be scoped to the individual stack's execution. This ensures that operations invoked nested within a stack will not be polluted with values from parent stack(s).

Fixes #914

@jasdel jasdel requested review from skmcgrail and skotambkar January 6, 2021 19:39
@jasdel jasdel force-pushed the jasdel/fixup/ContextScopedStackValues branch from dd6b8dd to 4452177 Compare January 8, 2021 00:07
aws/middleware/metadata.go Show resolved Hide resolved
@jasdel
Copy link
Contributor Author

jasdel commented Jan 8, 2021

Looks like this change is breaking presign URL behavior for EC2 client.

--- FAIL: TestClientCopySnapshot_presignURLCustomization (0.00s)
    --- FAIL: TestClientCopySnapshot_presignURLCustomization/auto_fill_presign_URL_matching_region (0.00s)
        api_op_CopySnapshot_test.go:117: expect no destination region, got mock-region
        api_op_CopySnapshot_test.go:122: expect presigned URL, got none
    --- FAIL: TestClientCopySnapshot_presignURLCustomization/auto_fill_presign_URL_different_region (0.00s)
        api_op_CopySnapshot_test.go:117: expect no destination region, got mock-region
        api_op_CopySnapshot_test.go:122: expect presigned URL, got none
FAIL
exit status 1
FAIL    github.com/aws/aws-sdk-go-v2/service/ec2        0.141s

jasdel added 5 commits January 8, 2021 10:36
Updates the SDK's middleware metadata to be scoped to the individual
stack's execution. This ensures that operations invoked nested
within a stack will not be polluted with values from parent stack(s).

Fixes #914
@jasdel jasdel force-pushed the jasdel/fixup/ContextScopedStackValues branch from 4452177 to 2e09e62 Compare January 8, 2021 19:09
@jasdel jasdel merged commit 292319d into main Jan 8, 2021
@jasdel jasdel deleted the jasdel/fixup/ContextScopedStackValues branch January 8, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer issue: STS Assume Role signature mismatch
3 participants