-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: Add endpoint source property #1070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
force-pushed
the
addEndpointSourceProperty
branch
from
January 22, 2021 19:21
8024501
to
a8c40b0
Compare
jasdel
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs change notes.
jasdel
reviewed
Jan 22, 2021
skotambkar
force-pushed
the
addEndpointSourceProperty
branch
from
January 22, 2021 20:25
a8c40b0
to
776fa46
Compare
skotambkar
force-pushed
the
addEndpointSourceProperty
branch
from
January 22, 2021 21:02
6bace65
to
890e07e
Compare
jasdel
approved these changes
Jan 22, 2021
This was referenced Mar 15, 2021
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
giantswarm/aws-ebs-csi-volume-limiter#8
Merged
Closed
build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
fsouza/s3-upload-proxy#157
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 15, 2021
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2 in /backend
WinWisely268/glasspolish#21
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/endpoints
: AddsEndpointSource
property toEndpoint
struct. This allows customers to provide an endpoint source, which can then be used to give SDK more context on handling custom Endpoints.