service/s3: Add documentation for using unseekable body PutObject and UploadPart #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional documentation to the PutObject and UploadPart operations on how to to use unseekable values to be uploaded to S3. Fixes aws#1108
Closed
…te hash Updates the v4 package with a new helper to swap out the compute payload hash middleware for the unsigned payload middleware. This allows API operations to be updated to not compute the payload hash, and use UNSIGNED-PAYLOAD instead.
jasdel
force-pushed
the
fixup/S3PutObjectDoc
branch
from
8717ac0 to
e955ccf
Compare
skotambkar
reviewed
Mar 17, 2021
| @Override | ||
| public byte getOrder() { | ||
| // This integration should happen before other integrations that rely on the presence of this trait | ||
| return -60; |
There was a problem hiding this comment.
Wouldn't pre-process model always run prior to usage of model? Don't think this ordering is required.
There was a problem hiding this comment.
Can remove. The ordering is always present, will inherit from parent if not defined here. But yeah I don't think order maters in this case. Other customizations where order model is pre-processed is where this will be relevant.
skotambkar
approved these changes
Mar 18, 2021
skmcgrail
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to the PutObject and UploadPart operations Body member how to upload unseekable objects to an Amazon S3 Bucket.
Fixes: #1108
Depends on: #1175