Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EndpointResolverWithOptions ignored issue #1514

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Fix EndpointResolverWithOptions ignored issue #1514

merged 5 commits into from
Dec 1, 2021

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Dec 1, 2021 •
edited
Loading 

+--------------------------------------+---------+---------+----------+------------------------------------+
|                  ID                  |  TYPE   | MODULES | COLLAPSE |            DESCRIPTION             |
+--------------------------------------+---------+---------+----------+------------------------------------+
| 954dde13-60ef-407d-8ecb-138e35fd6534 | feature |       1 | false    | Add support for specifying         |
|                                      |         |         |          | `EndpointResolverWithOptions`      |
|                                      |         |         |          | on `LoadOptions`, and associated   |
|                                      |         |         |          | `WithEndpointResolverWithOptions`. |
| f0080c1f-15ae-43c5-a697-801297110714 | bugfix  |     301 | true     | Fixes a bug that prevented         |
|                                      |         |         |          | aws.EndpointResolverWithOptions    |
|                                      |         |         |          | from being used by the service     |
|                                      |         |         |          | client.                            |
+--------------------------------------+---------+---------+----------+------------------------------------+

Fixes #1513

@skmcgrail skmcgrail requested a review from jasdel December 1, 2021 21:25
@skmcgrail skmcgrail merged commit d164d2c into aws:main Dec 1, 2021
@skmcgrail skmcgrail deleted the bugfix branch December 1, 2021 22:31
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
@skmcgrail @jrichardpfs
Fix EndpointResolverWithOptions ignored issue (aws#1514)
e020d93 
* Fix NewFromConfig EndpointResolver bug
* Regenerated Clients
* Clarify EndpointResolverWithOptions documentation.
* config: Add support for EndpointResolverWithOptions
* Add Changelog Annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cfg.EndpointResolverWithOptions is ignored when cfg.EndpointResolver is nil
2 participants
@skmcgrail @jasdel