Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Fix bug in SDK's merging of duration_seconds shared config #1568

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jan 21, 2022

Fixes the SDK's handling of duration_sections in the shared credentials file or specified in multiple shared config and shared credentials files under the same profile.

Fixes #1192
Related to #1193

Also removes init#Value.Append since it is never used.

Fixes the SDK's handling of `duration_sections` in the shared
credentials file or specified in multiple shared config and shared
credentials files under the same profile.

Fixes aws#1192
@jasdel jasdel force-pushed the fixup/DurationSeconds branch from 3ad0dc4 to 870624d Compare January 21, 2022 23:54
@jasdel jasdel changed the title config: add test case for role_duration_seconds parameter. config: Fix bug in SDK's merging of duration_seconds shared config Jan 21, 2022
@jasdel jasdel merged commit 14f5979 into aws:main Jan 24, 2022
@jasdel jasdel deleted the fixup/DurationSeconds branch January 24, 2022 16:54
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
…ws#1568)

Fixes the SDK's handling of `duration_sections` in the shared
credentials file or specified in multiple shared config and shared
credentials files under the same profile.

Fixes aws#1192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseInt Error with role duration seconds key
2 participants