feat: add object io reader/writer to manager #2622
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I wanna contribute an io.Reader for the DownloadManager and io.WriteCloser for the UploadManager.
I recently created my own wrapper s3io and figured I could just as well contribute the ObjectReader and ObjectWriter to the s3 sdk. (resolving issue #2247)
Having an io.Reader and io.Write(Close)r can significantly optimise memory consumption in your applications and is therefor a nice to have.
I designed it to also work in chunks/parts concurrently similar to how the current downloader/uploader work
This is my first PR here so maybe you can help me with the conventions.
Let me know what you think and if you'd like me to finish this