Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add implicit global region to internal partition metadata #2688

Merged
merged 2 commits into from
Jun 19, 2024
Merged

add implicit global region to internal partition metadata #2688

merged 2 commits into from
Jun 19, 2024

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Jun 18, 2024 •
edited
Loading

(note that this isn't used anywhere in rules currently*, but was just a missing field in the codegen for the partitions table)

@lucix-aws lucix-aws requested a review from a team as a code owner June 18, 2024 18:44
Madrigal
Madrigal approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Madrigal Madrigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. This is part of the model that comes with partitions.json as can be seen here

@lucix-aws lucix-aws merged commit 78777b6 into main Jun 19, 2024
12 checks passed
@lucix-aws lucix-aws deleted the feat-implicitglobalregion branch June 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wty-Bryant wty-Bryant wty-Bryant approved these changes

@Madrigal Madrigal Madrigal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucix-aws @Madrigal @wty-Bryant