Adds RestJson deserializer and middleware generation support #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
force-pushed
the
smithy/deserMiddleware
branch
2 times, most recently
from
4f031cf to
25d0f83
Compare
jasdel
suggested changes
May 29, 2020
There was a problem hiding this comment.
Good change, I think the biggest issue is the handling of unmodeled API errors, and putting modeled API errors in the out.Result field. All serialized error values should be returned as err. I think th eout.Result was to be reserved for successful unmodeled operation output shape.
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
JordonPhillips
suggested changes
May 29, 2020
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Show resolved
Hide resolved
… for output, error shapes
skotambkar
force-pushed
the
smithy/deserMiddleware
branch
from
60c29a0 to
b79d802
Compare
JordonPhillips
approved these changes
Jun 1, 2020
jasdel
suggested changes
Jun 1, 2020
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...o-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
jasdel
suggested changes
Jun 2, 2020
jasdel
approved these changes
Jun 2, 2020
skmcgrail
pushed a commit
to skmcgrail/aws-sdk-go-v2
that referenced
this pull request
Aug 21, 2020
* adds support for restjson deserializer middleware, json deserializers for output, error shapes * adds error check for discard unknown field deserializer util * suggested feedback * minor feedback updates
skmcgrail
pushed a commit
that referenced
this pull request
Sep 24, 2020
* adds support for restjson deserializer middleware, json deserializers for output, error shapes * adds error check for discard unknown field deserializer util * suggested feedback * minor feedback updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Related to aws/smithy-go#48