-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port V1 S3 Transfer Manager to V2 #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
Port V1 S3 Transfer Manager to V2 Smithy
Port V1 S3 Transfer Manager to V2 Smithy Client
Oct 8, 2020
skmcgrail
changed the title
Port V1 S3 Transfer Manager to V2 Smithy Client
Port V1 S3 Transfer Manager to V2
Oct 8, 2020
skmcgrail
force-pushed
the
portS3Manager
branch
5 times, most recently
from
October 12, 2020 17:07
b048dbe
to
0c627a7
Compare
jasdel
suggested changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like an accidental compiled test added to changes
s3manager/internal/integration/downloader/downloader.test
s3manager/internal/integration/uploader/uploader.test
skmcgrail
force-pushed
the
portS3Manager
branch
from
October 13, 2020 21:02
0c627a7
to
ce29076
Compare
jasdel
approved these changes
Oct 13, 2020
jasdel
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fresh port of the V1 S3 Transfer Manager
s3manager
to the V2 smithy design.Fixes #783