Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB Expression Package #981

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

skmcgrail
Copy link
Member

This PR re-introduces the feature/dynamodb/expression package.

Currently this branch is based on #975 thus the diff includes those changes. Will rebase this PR after that is merged in. For now leaving this as a draft.

Fixes: #894
Fixes: #713

Related: #115

@skmcgrail skmcgrail marked this pull request as ready for review December 16, 2020 03:16
feature/dynamodb/expression/doc.go Outdated Show resolved Hide resolved
feature/dynamodb/expression/go.mod Outdated Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the ddbExpression branch 2 times, most recently from e57dc13 to 3173800 Compare December 17, 2020 01:18
@zaquestion
Copy link
Contributor

@skmcgrail was there a reason for not including IsSet in these changes (#494), is there a different way this should be done in the refactored api?

zaquestion pushed a commit to zaquestion/aws-sdk-go-v2 that referenced this pull request Jul 1, 2021
These changes were present in an older version of the expression package before it was moved, originally added in aws#494, when the expression library was reintroduce in aws#981 these changes werent included for some reason, but the need for checking if a condition is set or not still exists
skmcgrail added a commit that referenced this pull request Jul 21, 2021
* feat: (feature/dynamodb/expression) readd IsSet methods

These changes were present in an older version of the expression package before it was moved, originally added in #494, when the expression library was reintroduce in #981 these changes werent included for some reason, but the need for checking if a condition is set or not still exists

* Add Change Annotation

Co-authored-by: Sean McGrail <mcgrails@amazon.com>
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
* feat: (feature/dynamodb/expression) readd IsSet methods

These changes were present in an older version of the expression package before it was moved, originally added in aws#494, when the expression library was reintroduce in aws#981 these changes werent included for some reason, but the need for checking if a condition is set or not still exists

* Add Change Annotation

Co-authored-by: Sean McGrail <mcgrails@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants