service/dynamodb/dynamodbattribute: Allow multiple struct tag elements (

#886) Updates the dynamodbattribute marshaler's parsing of the struct tag to not be artificially limited in number of elements. Removes the restriction on the number of elements in the struct tag.
aws · Oct 11, 2016 · 0b845ba · 0b845ba
1 parent d6072f0
commit 0b845ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/service/dynamodb/dynamodbattribute/tag.go b/service/dynamodb/dynamodbattribute/tag.go
@@ -33,7 +33,7 @@ func (t *tag) parseJSONTag(structTag reflect.StructTag) {
 }
 
 func (t *tag) parseTagStr(tagStr string) {
-	parts := strings.SplitN(tagStr, ",", 2)
+	parts := strings.Split(tagStr, ",")
 	if len(parts) == 0 {
 		return
 	}

diff --git a/service/dynamodb/dynamodbattribute/tag_test.go b/service/dynamodb/dynamodbattribute/tag_test.go
@@ -30,6 +30,8 @@ func TestTagParse(t *testing.T) {
 		{`dynamodbav:",binaryset"`, false, true, tag{AsBinSet: true}},
 		{`dynamodbav:",numberset"`, false, true, tag{AsNumSet: true}},
 		{`dynamodbav:",stringset"`, false, true, tag{AsStrSet: true}},
+		{`dynamodbav:",stringset,omitemptyelem"`, false, true, tag{AsStrSet: true,OmitEmptyElem:true}},
+		{`dynamodbav:"name,stringset,omitemptyelem"`, false, true, tag{Name: "name",AsStrSet: true,OmitEmptyElem: true}},
 	}
 
 	for i, c := range cases {