Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix /models/apis/Greengrass dep case sensitivity #1539

Closed
lokesh-shekar opened this issue Sep 21, 2017 · 2 comments · Fixed by #1541
Closed

fix /models/apis/Greengrass dep case sensitivity #1539

lokesh-shekar opened this issue Sep 21, 2017 · 2 comments · Fixed by #1541
Labels
duplicate This issue is a duplicate.

Comments

@lokesh-shekar
Copy link

Version of AWS SDK for Go?

version = "1.10.44". This would apply to all versions which had the #1538 changes merged.

Version of Go (go version)?

go version go1.9 darwin/amd64

What issue did you see?

  • We use https://github.com/golang/dep for dependency management.

  • Things were working fine until the above mentioned PR was merged

  • 'dep ensure' throws the below error.
    (59/59) Failed to write github.com/aws/aws-sdk-go@v1.10.49
    grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/aws/aws-sdk-go: : exit status 128

  • On trying to debug:
    $ cd $GOPATH/pkg/dep/sources/https---github.com-aws-aws--sdk--go/
    $ git status
    HEAD detached at 599f09b
    Changes not staged for commit:
    (use "git add ..." to update what will be committed)
    (use "git checkout -- ..." to discard changes in working directory)

    modified: models/apis/Greengrass/2017-06-07/api-2.json
    modified: models/apis/Greengrass/2017-06-07/docs-2.json

no changes added to commit (use "git add" and/or "git commit -a")

  • Since there already exists models/apis/greengrass (lowercase). This breaks many package managers, leading to conflict.

Steps to reproduce

  • Have a go code importing github.com/aws/aws-sdk-go
  • Use dep as your package manager
  • Run 'dep ensure' command and you hit the above error.
@ilovezfs
Copy link

This breaks with glide install too, when attempting to build terragrunt, which depends on aws-sdk-go. See gruntwork-io/terragrunt#296.

@jasdel
Copy link
Contributor

jasdel commented Sep 21, 2017

Thanks for reporting this issue let's use #1540 to tack this issue.

@jasdel jasdel closed this as completed Sep 21, 2017
@jasdel jasdel added the duplicate This issue is a duplicate. label Sep 21, 2017
jasdel added a commit that referenced this issue Sep 21, 2017
…1541)

Fixes the greengrass service model folder being duplicated as Greengrass. The duplicate folders occurred due to an upstream error internal SDK release that will be fixed separately. This change should correct the issues with dep and other tools failing because of the duplicate folder name.

Fix #1540
Fix #1539
@awstools awstools mentioned this issue Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants